Skip to content

Remove all migrate.nll.stderr files#91087

Merged
bors merged 1 commit intorust-lang:masterfrom
rukai:fix_test_nll_revisions
Dec 1, 2021
Merged

Remove all migrate.nll.stderr files#91087
bors merged 1 commit intorust-lang:masterfrom
rukai:fix_test_nll_revisions

Conversation

@rukai
Copy link
Contributor

@rukai rukai commented Nov 20, 2021

There are a few ui tests that setup the revisions like:

// revisions: migrate nll`
// [nll]compile-flags: -Zborrowck=mir

However most of them fail to disable the nll compare mode like this:

// ignore-compare-mode-nll

This ends up generating confusing files ending in .migrate.nll.stderr because the nll compare mode is run on top of the migrate revision.

This PR fixes this by adding ignore-compare-mode-nll to these tests.

I would have just made these tests use compare modes instead but I assume the reason these tests are messing around with revisions instead of just letting the nll compare mode do its thing is to enforce error annotations for both migrate and nll.
Relying on just compare modes would only have the error annotations for migrate.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants